From 0f72f9ba1f0586afac67bc88f35eba5cc26392cd Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 2 Feb 2017 12:50:35 +0100 Subject: [PATCH] x86/HVM: make hvm_find_io_handler() static This reduces the chance of misuse - calling it must in particular always be accompanied by calling the corresponding ->complete() hook. Constify its parameter at once. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- xen/arch/x86/hvm/intercept.c | 2 +- xen/include/asm-x86/hvm/io.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c index bf141c9905..721fb38030 100644 --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -210,7 +210,7 @@ int hvm_process_io_intercept(const struct hvm_io_handler *handler, return rc; } -const struct hvm_io_handler *hvm_find_io_handler(ioreq_t *p) +static const struct hvm_io_handler *hvm_find_io_handler(const ioreq_t *p) { struct domain *curr_d = current->domain; unsigned int i; diff --git a/xen/include/asm-x86/hvm/io.h b/xen/include/asm-x86/hvm/io.h index 41ade5c959..d6801c17e0 100644 --- a/xen/include/asm-x86/hvm/io.h +++ b/xen/include/asm-x86/hvm/io.h @@ -97,8 +97,6 @@ struct hvm_io_ops { int hvm_process_io_intercept(const struct hvm_io_handler *handler, ioreq_t *p); -const struct hvm_io_handler *hvm_find_io_handler(ioreq_t *p); - int hvm_io_intercept(ioreq_t *p); struct hvm_io_handler *hvm_next_io_handler(struct domain *d); -- 2.30.2